This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFC/RFA] enable break
- From: Michael Snyder <msnyder at vmware dot com>
- To: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 18 Jun 2010 18:12:51 -0700
- Subject: [RFC/RFA] enable break
I happened to notice that if you say "help disable", you get a list
of sub-commands that includes "disable breakpoints", but if you say
"help enable", the list of sub-commands, does NOT include "enable
breakpoints". It also doesn't tab-complete on "enable br<tab>".
On investigation, I discovered that the "enable breakpoints" command
is instantiated using "add_abbrev_prefix_cmd". What the heck -- it's
not an abbreviation. This dates back to before the current cvs repo.
Changing that call to "add_prefix_cmd" fixes the issues, and causes
no regressions when tested on amd64-linux.
OK to commit?
2010-06-18 Michael Snyder <msnyder@vmware.com>
* breakpoint.c (_initialize_breakpoint): Use add_prefix_cmd,
not add_abbrev_prefix_cmd, for "enable breakpoints".
Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.490
diff -u -p -r1.490 breakpoint.c
--- breakpoint.c 16 Jun 2010 18:30:30 -0000 1.490
+++ breakpoint.c 19 Jun 2010 01:03:40 -0000
@@ -11264,7 +11264,7 @@ With a subcommand you can enable tempora
add_com_alias ("en", "enable", class_breakpoint, 1);
- add_abbrev_prefix_cmd ("breakpoints", class_breakpoint, enable_command, _("\
+ add_prefix_cmd ("breakpoints", class_breakpoint, enable_command, _("\
Enable some breakpoints.\n\
Give breakpoint numbers (separated by spaces) as arguments.\n\
This is used to cancel the effect of the \"disable\" command.\n\