Re: [1/7] RFC: minimal BFD thread awareness

[Jan Kratochvil <jan dot kratochvil at redhat dot com>]

Hi Tom,

On Mon, 14 Jun 2010 20:22:56 +0200, Tom Tromey wrote:
> --- a/bfd/bfd-in2.h
> +++ b/bfd/bfd-in2.h
> @@ -2572,6 +2572,8 @@ relocation types already defined.  */
> +  BFD_RELOC_SPU_PIC18,
> +  BFD_RELOC_SPU_STUB,
> --- a/bfd/libbfd.h
> +++ b/bfd/libbfd.h
> +  "BFD_RELOC_SPU_PIC18",
> +  "BFD_RELOC_SPU_STUB",

Isn't this some leftover?


> --- a/bfd/bfd-in2.h
> +++ b/bfd/bfd-in2.h
> @@ -5353,6 +5355,25 @@ bfd_boolean core_file_matches_executable_p
> +struct bfd_thread_info
> +{
> +  /* Return the ID of the current thread.  Should never return NULL.  */
> +  void *(*self) (void);
> +  /* Create a mutex and return it.  */
> +  void *(*create_mutex) (void);

I would prefer some opaque struct * typedefs so that the mutex vs.  thread-id
have incompatible types.


Thanks,
Jan