[patch] new testcase: Internal error on unqualified name re-set (PR 11657)

[Jan Kratochvil <jan dot kratochvil at redhat dot com>]

Hi,

filed for it: http://sources.redhat.com/bugzilla/show_bug.cgi?id=11657

break C::C will create a pending breakpoint.
Later it gets resolved into both C::C() and C::C(int) which crashes GDB:
	breakpoint.c:9641: internal-error: breakpoint_re_set_one: Assertion `sals.nelts == 1' failed.

It is the same problem as existing:
	FAIL: gdb.objc/objcdecode.exp: continue after break on multiply defined symbol (GDB internal error)
but this testcase is not dependent on objc (only on C++).

static int
breakpoint_re_set_one (void *bint)
      if (!not_found)
        {
-->       gdb_assert (sals.nelts == 1);

I ask now only for a testcase check-in.

Proposing for a later fix just to completely disable the unqualified names
resolution for C++.  C::C<tab> would autocomplete it to C::C() if there are no
other choices.


Thanks,
Jan


gdb/testsuite/
2010-06-02  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* gdb.cp/re-set-overloaded.exp, gdb.cp/re-set-overloaded.cc: New.

--- /dev/null
+++ b/gdb/testsuite/gdb.cp/re-set-overloaded.cc
@@ -0,0 +1,26 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+   Copyright 2010 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+class C
+  {
+  public:
+    C() {}
+    C(int x) {}
+  };
+
+C a;
+C b(1);
--- /dev/null
+++ b/gdb/testsuite/gdb.cp/re-set-overloaded.exp
@@ -0,0 +1,59 @@
+# Copyright 2010 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+if { [skip_cplus_tests] } { continue }
+if { [skip_shlib_tests] } { continue }
+
+set testfile re-set-overloaded
+set srcfile bool.cc
+set executable $testfile
+set binfile $objdir/$subdir/$executable
+
+set libsrcfile ${testfile}.cc
+set sofile $objdir/$subdir/${testfile}.so
+
+# Create and source the file that provides information about the compiler
+# used to compile the test case.
+if [get_compiler_info ${binfile} "c++"] {
+    return -1
+}
+
+if { [gdb_compile_shlib $srcdir/$subdir/$libsrcfile $sofile {debug c++}] != ""
+     || [gdb_compile $srcdir/$subdir/$srcfile $binfile executable [list debug "c++" shlib=${sofile}]] != ""} {
+    untested ${testfile}.exp
+    return -1
+}
+
+clean_restart $executable
+gdb_load_shlibs ${sofile}
+
+gdb_test_no_output "set breakpoint pending yes"
+gdb_test "break C::C" {Breakpoint [0-9]+ \(C::C\) pending\.} "break C::C"
+gdb_test_no_output {set variable $brk = $bpnum}
+
+gdb_breakpoint "main"
+gdb_run_cmd
+gdb_test "" "" "start"
+
+set test "breakpoint resolved"
+gdb_test_multiple {info breakpoints $brk} $test {
+    -re "<PENDING>" {
+	fail $test
+    }
+    -re "\r\n$gdb_prompt $" {
+	# FIXME: Check more specific resolution state.
+	pass $test
+    }
+}