This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Remove redundant symbol naming from new_symbol
- From: Keith Seitz <keiths at redhat dot com>
- To: gdb-patches at sourceware dot org
- Cc: sami wagiaalla <swagiaal at redhat dot com>
- Date: Tue, 01 Jun 2010 12:21:33 -0700
- Subject: Re: [patch] Remove redundant symbol naming from new_symbol
- References: <4BFE83F0.2090908@redhat.com>
On 05/27/2010 07:38 AM, sami wagiaalla wrote:
This patch removes the redundant calls.
FWIW, I think this patch should be approved; the additional calls to
dwarf2_full_name do appear to be redundant, since SYMBOL_SET_NAMES is
called unconditionally for every symbol with DW_AT_name.
[The only question is whether dwarf2_full_name and dwarf2_physname could
return different "names" for these DIEs, and since the DIEs do not
represent a class method, the "names" will be identical.]
Keith