This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[obv] testsuite: Remove sent trailing newlines
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Tue, 1 Jun 2010 19:25:39 +0200
- Subject: [obv] testsuite: Remove sent trailing newlines
Hi,
the gdb.base/commands.exp change has no effect, empty leading line in the GDB
commands list gets ignored. But it was IMO apparently excessive / by mistake.
The gdb.mi/mi-nsintrall.exp is also harmless, empty line in MI mode will
generate just some additional output like:
(gdb)
&"\n"
^done
(gdb)
But the gdb.java/jmisc.exp change is a racy FAIL fix causing:
p *args^M
^M
$2 = {length: 0}^M
(gdb) ^M
$3 = {length: 0}^M
(gdb) FAIL: gdb.java/jmisc.exp: p *args
Checked-in.
Thanks,
Jan
http://sourceware.org/ml/gdb-cvs/2010-06/msg00004.html
--- src/gdb/testsuite/ChangeLog 2010/05/31 23:20:19 1.2295
+++ src/gdb/testsuite/ChangeLog 2010/06/01 17:22:32 1.2296
@@ -1,3 +1,11 @@
+2010-06-01 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ * gdb.base/commands.exp (begin commands on watch): Remove excessive
+ trailing newline.
+ * gdb.mi/mi-nsintrall.exp (-gdb-show non-stop): Likewise.
+ * gdb.java/jmisc.exp (p *args\n): Rename to ...
+ (p *args): ... here and remove excessive trailing newline.
+
2010-05-31 Joel Brobecker <brobecker@adacore.com>
* gdb.base/subst.exp: Fix call to gdb_test with empty message.
--- src/gdb/testsuite/gdb.base/commands.exp 2010/05/24 22:03:58 1.35
+++ src/gdb/testsuite/gdb.base/commands.exp 2010/06/01 17:22:33 1.36
@@ -284,7 +284,7 @@
if {$wp_id == -1} {return}
- gdb_test_multiple "commands $wp_id\n" "begin commands on watch" {
+ gdb_test_multiple "commands $wp_id" "begin commands on watch" {
-re "Type commands for breakpoint.*, one per line.*>$" {
pass "begin commands on watch"
}
--- src/gdb/testsuite/gdb.java/jmisc.exp 2010/05/26 18:34:12 1.18
+++ src/gdb/testsuite/gdb.java/jmisc.exp 2010/06/01 17:22:33 1.19
@@ -81,7 +81,7 @@
gdb_test "p args" \
"\\\$1 = java\.lang\.String\\\[]@\[a-f0-9]+"
- gdb_test_multiple "p *args\n" "p *args\n" {
+ gdb_test_multiple "p *args" "p *args" {
-re "\\\$2 = \{length: 0\}\[\r\n\ \t]+$gdb_prompt $" {
pass "p *args"
}
--- src/gdb/testsuite/gdb.mi/mi-nsintrall.exp 2010/05/26 18:12:13 1.6
+++ src/gdb/testsuite/gdb.mi/mi-nsintrall.exp 2010/06/01 17:22:33 1.7
@@ -37,7 +37,7 @@
mi_gdb_load $binfile
set supported 0
-gdb_test_multiple "-gdb-show non-stop\n" "" {
+gdb_test_multiple "-gdb-show non-stop" "" {
-re ".*\\^done,value=\"off\",supported=\"(\[^\"\]+)\"\r\n$mi_gdb_prompt$" {
if { $expect_out(1,string) == "1" } {
set supported 1