This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFC] windows-nat.c: New oddity after copy console information for new console patch.
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: <gdb-patches at sourceware dot org>
- Date: Tue, 1 Jun 2010 08:57:15 +0200
- Subject: [RFC] windows-nat.c: New oddity after copy console information for new console patch.
- References: <001901caf934$fd580460$f8080d20$@muller@ics-cnrs.unistra.fr> <20100525205241.GA5298@ednor.casa.cgf.cx> <000601cafca7$ead3af80$c07b0e80$@muller@ics-cnrs.unistra.fr> <20100526170712.GA32594@ednor.casa.cgf.cx> <001801cafd69$018b9a00$04a2ce00$@muller@ics-cnrs.unistra.fr> <001e01cafd6c$2a0c87c0$7e259740$@muller@ics-cnrs.unistra.fr> <20100527151730.GA483@ednor.casa.cgf.cx> <001201cafe4e$e885afa0$b9910ee0$@muller@ics-cnrs.unistra.fr> <20100530171041.GB8605@ednor.casa.cgf.cx>
> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Christopher Faylor
> Envoyé?: Sunday, May 30, 2010 7:11 PM
> À?: gdb-patches@sourceware.org; Pierre Muller
> Objet?: Re: [RFA] windows-nat.c: Copy console information for new
> console
>
> On Fri, May 28, 2010 at 12:16:59PM +0200, Pierre Muller wrote:
> >> >> From Christopher Faylor
> >> >> I actually thought fairly carefully about flags. If you have a
> >> >> function
> >> >> which controls console info, then the function should set the
> flags
> >> >> appropriately to deal with the console info.
> >> >
> >> >
> >> > As you prefer,
> >> >here is a new version that also takes DWORD *flags as parameter.
> >> > I also tried to explain a little bit better
> >> >what the function tries to do.
> >>
> >> Thanks. Looks good. I forgot to say: Thanks for doing this. It
> >> looks like
> >> a nice improvement.
> >
> > Hi Christopher,
> > does this mean that you want to test it
> >a little bit more before you give some more detailed
> >review or should I understand this as an approval?
>
> Wow. You like to go back and forth don't you?
Not really, but I prefer to ask once more rather
than doing something wrong.
> Just apply it already.
Applied yesterday...
But I just noticed a strange, probably unwanted effect of my patch:
I you debug a GUI application that starts its main window at default size,
this size is now different depending on the
state on the `new-console' switch:
- if new-console is off, the default size is chosen by the system
(probably as before my patch),
- if new-console is on, the size of the start window will be forced
by the settings of dwXSize and dwYSize fields of the STARTUPINFO
structure together with the STARTF_USESIZE flag.
Should we change this?
We could condition the call to windows_set_console_info
on the fact that the executable to start is not a GUI application,
but I am not sure how to check this within GDB code.
Suggestions most welcome,
Pierre Muller
Pascal language support maintainer for GDB