This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [python][patch] Return hash value for gdb.Value.


>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> This patch implements the hash function for gdb.Value. It purely
Phil> replicates the function of id() in that it returns the object
Phil> address as the hash value. This allows gdb.Values to be hashable.

Thanks for doing this.

Phil> 2010-05-13  Phil Muldoon  <pmuldoon@redhat.com>

Phil> 	* gdb.python/py-value.exp (test_value_hash): New function.

Mention the PR number here too.

Phil> +long valpy_hash (PyObject *self)

Should be 'static'.
Newline after 'long'.

Ok with those changes.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]