This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PING] [RFC/Windows] Remember last tlb type for re-use in windows_get_tlb_type
- From: Tom Tromey <tromey at redhat dot com>
- To: gdb-patches at sourceware dot org
- Cc: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Date: Fri, 30 Apr 2010 10:17:09 -0600
- Subject: Re: [PING] [RFC/Windows] Remember last tlb type for re-use in windows_get_tlb_type
- References: <000f01cadf9e$a4fd4910$eef7db30$@muller@ics-cnrs.unistra.fr> <002401cae7ea$ba4b48e0$2ee1daa0$@muller@ics-cnrs.unistra.fr> <20100430145338.GA11512@ednor.casa.cgf.cx> <2540.9180707813$1272639973@news.gmane.org> <m363393qzq.fsf@fleche.redhat.com> <20100430153441.GB11512@ednor.casa.cgf.cx>
- Reply-to: Tom Tromey <tromey at redhat dot com>
>>>>> "cgf" == Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org> writes:
cgf> Attaching them to gdbarch would make them permanent for the life of the
cgf> debugging session right? That seems better but I agree that, in practice,
cgf> this is probably just as good.
Yeah, but it would fix a leak that is latent even with Pierre's latest
patch: if you use the TLB, switch arches, use it again, then switch
back, and use it a third time, then that third time will recreate the
types. If the types were attached to the gdbarch, then the third use
would reuse the types created the first time through.
My guess is that this sort of scenario is rare.
Tom