This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: D language support
- From: Tom Tromey <tromey at redhat dot com>
- To: Mihail Zenkov <mihail dot zenkov at gmail dot com>
- Cc: Joel Brobecker <brobecker at adacore dot com>, gdb-patches at sourceware dot org
- Date: Tue, 20 Apr 2010 15:39:17 -0600
- Subject: Re: D language support
- References: <20091224015617.7092112b.mihai.zenkov@gmail.com> <20091230125539.GF2788@adacore.com> <20100109082524.263bcb17.mihai.zenkov@gmail.com> <20100109082830.dd984de8.mihai.zenkov@gmail.com> <20100109142327.GC2007@adacore.com> <20100113064026.14f75ff2.mihai.zenkov@gmail.com> <m3ljfzaxlk.fsf@fleche.redhat.com> <20100415012124.91ce1769.mihai.zenkov@gmail.com>
- Reply-to: tromey at redhat dot com
>>>>> "Mihail" == Mihail Zenkov <mihail.zenkov@gmail.com> writes:
Mihail> Sorry for too very long delay. I fix patch as you and Joel
Mihail> suggested, i hope it ready for inclusion.
It is very close. In fact, I think I only saw formatting nits.
Thanks for working on this.
I think this needs a NEWS entry.
Mihail> gdb/ChangeLog:
[...]
Mihail> * doc/gdb.texinfo: Add mention about D language support.
[...]
Mihail> * testsuite/gdb.base/default.exp: Fix "set language" test.
These directories have their own ChangeLog files, so you have to split
up the entry.
Mihail> +extern void c_emit_char (int c, struct type *type, struct ui_file *stream, int quoter);
This wraps past 80 columns, so it should be split after the second comma.
Mihail> +static const char* mangled_str;
GDB style is "const char *mangled_str" -- the "*" is in the wrong place.
Mihail> + obstack_blank(&tempbuf, -1);
Space before open paren.
Mihail> + } else if (strncmp (mangled_str, "__Class_", 8) == 0)
Newline before "else".
Mihail> +extern int d_val_print (struct type *type, const gdb_byte *valaddr,
Mihail> + int embedded_offset, CORE_ADDR address,
Mihail> + struct ui_file *stream, int recurse,
Mihail> + const struct value_print_options *options);
Mihail> +#endif /* !defined (D_LANG_H) */
Blank line before the #endif.
thanks,
Tom