Re: [patch] break-interp.exp: handle /usr/sbin/prelink.bin

[Mike Frysinger <vapier at gentoo dot org>]

On Thursday 18 March 2010 03:26:20 Doug Evans wrote:
> On Thu, Mar 18, 2010 at 12:15 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> > On Thursday 18 March 2010 02:15:07 Doug Evans wrote:
> >> -    if {$result == 1 && [regexp {^(/usr/sbin/prelink: [^ ]* does not
> >> have .gnu.prelink_undo section\n?)*$} $output]} {
> >> +    if {$result == 1 && [regexp {^(/usr/sbin/prelink[^ ]*: [^ ]* does
> >> not have .gnu.prelink_undo section\n?)*$} $output]} {
> > 
> > since the prelink filename shouldnt have a colon in it, should that be
> > used in the regex instead ?
> > /usr/sbin/prelink[^:]*:
> 
> Either is arguably wrong IMO.  Why can't the program have a colon or
> space in its name?

i said "shouldnt", not "cant".  i was thinking from a practical standpoint -- 
spaces are much more common than colons in filenames, and colons are generally 
discouraged from paths because they break fundamental things like colon-
separated variables such as $PATH.

> But I don't have a strong opinion on which one to actually use, or
> something else.

just a suggestion; i dont particularly care as i dont deal with prelink.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.