Re: [MI tracepoints 7/9] -trace-find

[Vladimir Prus <vladimir at codesourcery dot com>]

On Tuesday 16 March 2010 03:27:53 Pedro Alves wrote:

> I stopped a few minor issues.
> 
> On Sunday 14 March 2010 08:59:44, Vladimir Prus wrote:
> > +    error ("May not look at trace frames while trace is running.");
> 
> Missing i18n.
> 
> > +  else if (strcmp (mode, "tracepoint-number") == 0)
> > +    {
> > +      if (argc != 2)
> > +       error (_("frame number is required"));
> > +      tfind_1 (tfind_tp, atoi (argv[1]), 0, 0, 0);
> > +    }
> 
> You mean, "tracepoint number is required".
> 
> On Sunday 14 March 2010 08:59:44, Vladimir Prus wrote:
> > -      TPP.  */
> > +      TPP.  If no trace frame matches, return -1. ay throw if the
>                                                    ^^^
> 
> "-1.  May throw"
> 
> 

Thanks for the review. I've fixed those issues locally.

-- 
Vladimir Prus
CodeSourcery
vladimir@codesourcery.com
(650) 331-3385 x722