This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gdb: tests/monitor: set remotetimeout to gdb_load_timeout for remote targets


On 03/15/2010 08:42 AM, Joel Brobecker wrote:
	* gdb/testsuite/config/monitor.exp (gdb_load): New decimal variable.
	Save remotetimeout setting in oldremotetimeout.  Set remotetimeout to
	$loadtimeout.  Restore when done.

Do you have to use send_gdb/gdb_expect in this file, or can you use gdb_test, or gdb_test_multiple?

Watch out for stray semicolon at the end of a few statements. Eg:

+ send_gdb "set remotetimeout $oldremotetimeout\n";
^^^
I will see if I can find some time later today to fix these. Thanks for review.

--
Jie Zhang
CodeSourcery
(650) 331-3385 x735


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]