This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Add support for imported declaration and correct search order


On Thu, 25 Feb 2010 21:14:15 +0100, Sami Wagiaalla wrote:
>    retval->import_src = savestring (src, strlen(src));
>    retval->import_dest = savestring (dest, strlen(dest));
...
> +    retval->declaration = savestring (declaration, strlen (declaration));

(sure really only a nitpick)

These savestring calls can be simplified to:
# +    retval->declaration = xstrdup (declaration);

as was cleaned up by:
	[obv] Replace savestring by xstrdup where possible
	http://sourceware.org/ml/gdb-patches/2009-05/msg00516.html

but new `savestring (X, strlen (X))' calls apparently crept in since that time.


Thanks,
Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]