This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

PATCH: PR shlibs/11293: gdb is broken on Linux/i386


Hi,

ULONGEST is 64bit on Linux/i386.  We should check CORE_ADDR instead
of ULONGEST for address size. OK to install?

Thanks.


H.J.
--
2010-02-17  H.J. Lu  <hongjiu.lu@intel.com>

	PR shlibs/11293
	* solib-svr4.c (enable_break): Check size of CORE_ADDR instead
	of ULONGEST for address size.

diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c
index b3b9e00..f4fccb2 100644
--- a/gdb/solib-svr4.c
+++ b/gdb/solib-svr4.c
@@ -1459,7 +1459,7 @@ enable_break (struct svr4_info *info, int from_tty)
 	       invalid addresses like 0x101234567 for 32bit inferiors on 64bit
 	       GDB.  */
 
-	    if (addr_bit < (sizeof (ULONGEST) * HOST_CHAR_BIT))
+	    if (addr_bit < (sizeof (CORE_ADDR) * HOST_CHAR_BIT))
 	      {
 		CORE_ADDR space_size = (ULONGEST) 1 << addr_bit;
 		CORE_ADDR tmp_entry_point = exec_entry_point (tmp_bfd,


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]