This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
PATCH: PR tui/9622: tui over-eagerly initializes readline
- From: "H.J. Lu" <hongjiu dot lu at intel dot com>
- To: GDB <gdb-patches at sourceware dot org>
- Date: Thu, 4 Feb 2010 09:07:00 -0800
- Subject: PATCH: PR tui/9622: tui over-eagerly initializes readline
- Reply-to: "H.J. Lu" <hjl dot tools at gmail dot com>
We shouldn't initialize readline if gdb_stdout isn't a tty. OK
to install?
Thanks.
H.J.
---
2010-02-04 H.J. Lu <hongjiu.lu@intel.com>
PR tui/9622
* tui/tui-interp.c (tui_init): Call tui_initialize_readline
only if gdb_stdout is a tty.
diff --git a/gdb/tui/tui-interp.c b/gdb/tui/tui-interp.c
index 3b59769..3bb8246 100644
--- a/gdb/tui/tui-interp.c
+++ b/gdb/tui/tui-interp.c
@@ -57,7 +57,8 @@ tui_init (int top_level)
tui_initialize_io ();
tui_initialize_win ();
- tui_initialize_readline ();
+ if (ui_file_isatty (gdb_stdout))
+ tui_initialize_readline ();
return NULL;
}