This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[ob] Fix gdbarch.sh error
- From: Daniel Jacobowitz <dan at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Date: Mon, 1 Feb 2010 11:58:06 -0500
- Subject: [ob] Fix gdbarch.sh error
I got the definition of gdbarch_remote_breakpoint_for_pc wrong; all
non-ARM ports would (briefly) fail with an internal error at startup.
Fixed as below.
I also propogated a fix from observer.sh; LC_ALL should be set to "C",
not "c".
--
Daniel Jacobowitz
CodeSourcery
2010-02-01 Daniel Jacobowitz <dan@codesourcery.com>
* gdbarch.sh: Set LANG and LC_ALL to C, not c.
(remote_breakpoint_for_pc): Correct invalid_p check.
* gdbarch.c: Regenerated.
Index: gdbarch.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbarch.c,v
retrieving revision 1.459
diff -u -p -r1.459 gdbarch.c
--- gdbarch.c 1 Feb 2010 16:09:19 -0000 1.459
+++ gdbarch.c 1 Feb 2010 16:56:15 -0000
@@ -596,8 +596,7 @@ verify_gdbarch (struct gdbarch *gdbarch)
fprintf_unfiltered (log, "\n\tinner_than");
if (gdbarch->breakpoint_from_pc == 0)
fprintf_unfiltered (log, "\n\tbreakpoint_from_pc");
- if (gdbarch->remote_breakpoint_from_pc == default_remote_breakpoint_from_pc)
- fprintf_unfiltered (log, "\n\tremote_breakpoint_from_pc");
+ /* Skip verify of remote_breakpoint_from_pc, invalid_p == 0 */
/* Skip verify of adjust_breakpoint_address, has predicate */
/* Skip verify of memory_insert_breakpoint, invalid_p == 0 */
/* Skip verify of memory_remove_breakpoint, invalid_p == 0 */
Index: gdbarch.sh
===================================================================
RCS file: /cvs/src/src/gdb/gdbarch.sh,v
retrieving revision 1.503
diff -u -p -r1.503 gdbarch.sh
--- gdbarch.sh 1 Feb 2010 16:09:20 -0000 1.503
+++ gdbarch.sh 1 Feb 2010 16:56:16 -0000
@@ -22,8 +22,8 @@
# Make certain that the script is not running in an internationalized
# environment.
-LANG=c ; export LANG
-LC_ALL=c ; export LC_ALL
+LANG=C ; export LANG
+LC_ALL=C ; export LC_ALL
compare_new ()
@@ -489,7 +489,7 @@ m:const gdb_byte *:breakpoint_from_pc:CO
# Return the adjusted address and kind to use for Z0/Z1 packets.
# KIND is usually the memory length of the breakpoint, but may have a
# different target-specific meaning.
-m:void:remote_breakpoint_from_pc:CORE_ADDR *pcptr, int *kindptr:pcptr, kindptr::default_remote_breakpoint_from_pc:
+m:void:remote_breakpoint_from_pc:CORE_ADDR *pcptr, int *kindptr:pcptr, kindptr:0:default_remote_breakpoint_from_pc::0
M:CORE_ADDR:adjust_breakpoint_address:CORE_ADDR bpaddr:bpaddr
m:int:memory_insert_breakpoint:struct bp_target_info *bp_tgt:bp_tgt:0:default_memory_insert_breakpoint::0
m:int:memory_remove_breakpoint:struct bp_target_info *bp_tgt:bp_tgt:0:default_memory_remove_breakpoint::0