This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Fix for PR gdb/10819
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Paul Pluzhnikov <ppluzhnikov at google dot com>
- Cc: gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Thu, 22 Oct 2009 07:47:58 +0200
- Subject: Re: [patch] Fix for PR gdb/10819
- References: <8ac60eac0910212148w24f44d53xfa6bedd7e12b41d1@mail.gmail.com>
On Thu, 22 Oct 2009 06:48:06 +0200, Paul Pluzhnikov wrote:
> Attached is a patch to fix PR gdb/10819
> http://sourceware.org/bugzilla/show_bug.cgi?id=10819
[...]
> + if (cie_table->num_entries == 0)
> + return NULL;
> +
> p_cie = bsearch (&cie_pointer, cie_table->entries, cie_table->num_entries,
> sizeof (cie_table->entries[0]), bsearch_cie_cmp);
> if (p_cie != NULL)
I would find appropriate there a comment it is a Solaris bug workaround, the
condition looks to me as clearly redundant there now.
Thanks,
Jan