This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Fix for internal-error: linux_nat_post_attach_wait: Assertion `pid == new_pid && WIFSTOPPED (status)' failed.
On Wed, Oct 14, 2009 at 3:29 PM, Pedro Alves <pedro@codesourcery.com> wrote:
> Something else I noticed:
>
>> + ? ? ? ? int signo = WTERMSIG (status);
>
> Should be:
>
> ? ? ? ?enum target_signal signo = target_signal_from_host (WTERMSIG (status));
>
>> +
>> + ? ? ? ? target_terminal_ours ();
>> + ? ? ? ? target_mourn_inferior ();
>> + ? ? ? ? error (_("During startup program terminated with signal %s, %s."),
>> + ? ? ? ? ? ? ? ?target_signal_to_name (signo),
>> + ? ? ? ? ? ? ? ?target_signal_to_string (signo));
>
> ? ? ? ? ? ? ? ? ? ^^^^^^^^^^^^^^^^^^^^^^^
>
> because these functions take a target independent gdb
> signal (TARGET_SIGNAL_...). ?Yes, it's confusing.
These kinds of errors should be caught by the compilation system or language.
Then it wouldn't be confusing at all.