This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 2/2] Perform a namespace lookup at every block level
- From: Tom Tromey <tromey at redhat dot com>
- To: Sami Wagiaalla <swagiaal at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Tue, 13 Oct 2009 14:22:33 -0600
- Subject: Re: [patch 2/2] Perform a namespace lookup at every block level
- References: <4A57512A.7090208@redhat.com> <20090710194949.GA2064@caradoc.them.org> <4A5B68A4.30006@redhat.com> <4A68B91D.2080206@redhat.com> <4A8B0FD9.7010603@redhat.com> <4AA14648.7090600@redhat.com>
- Reply-to: tromey at redhat dot com
>>>>> "Sami" == Sami Wagiaalla <swagiaal@redhat.com> writes:
Sami> + return cp_lookup_symbol_namespace(scope, name, linkage_name, block, domain, 1);
Missing space before "(". There are a few of these.
Sami> + search_parents );
Extra space.
Sami> + directive_match = search_parents ?
Sami> + strncmp (scope, current->import_dest,
Sami> + strlen(current->import_dest)) == 0 :
Sami> + strcmp (scope, current->import_dest) == 0;
GNU style is to line break before an operator, not after.
There are several instances of this.
Sami> +############################################
Sami> +# Test that the search can fail efficiently
Sami> +
Sami> +gdb_test "print y" "No symbol \"y\" in current context."
I like the test case :)
Sami> - VAR_DOMAIN);
Sami> + VAR_DOMAIN,1);
Missing space after the ",".
Tom