This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Set calling convention of methods
- From: Tom Tromey <tromey at redhat dot com>
- To: Jonas Maebe <jonas dot maebe at elis dot ugent dot be>
- Cc: Joel Brobecker <brobecker at adacore dot com>, Mark Kettenis <mark dot kettenis at xs4all dot nl>, gdb-patches at sourceware dot org
- Date: Wed, 30 Sep 2009 10:46:47 -0600
- Subject: Re: [patch] Set calling convention of methods
- References: <B8DEF338-C0F0-40A5-B4B8-D24DC56BFA0E@elis.ugent.be> <m31vs0s9da.fsf@fleche.redhat.com> <7B6EF4DA-76C8-4D9C-8B9F-94153EF1C4E1@elis.ugent.be> <m3zleb2ne3.fsf@fleche.redhat.com> <691B0BA8-C606-42FF-A796-76CC9C31556A@elis.ugent.be> <200904222215.n3MMF0p2006994@brahms.sibelius.xs4all.nl> <19C107AA-5271-4C23-A6D2-AFF75BBAC4E4@elis.ugent.be> <m3bpp3oode.fsf@fleche.redhat.com> <5AA3BCA9-1ECF-446E-8B49-3132F0E470FB@elis.ugent.be> <20090930000225.GA10338@adacore.com> <8F3B6095-4766-432D-ABB5-AB4DAA2D5572@elis.ugent.be>
- Reply-to: Tom Tromey <tromey at redhat dot com>
>>>>> "Jonas" == Jonas Maebe <jonas.maebe@elis.ugent.be> writes:
>> diff --git a/include/elf/dwarf2.h b/include/elf/dwarf2.h
>>> index a7448dc..efa786e 100644
>>> --- a/include/elf/dwarf2.h
>>> +++ b/include/elf/dwarf2.h
>>> @@ -662,7 +662,8 @@ enum dwarf_calling_convention
>>> DW_CC_normal = 0x1,
>>> DW_CC_program = 0x2,
>>> DW_CC_nocall = 0x3,
>>> - DW_CC_GNU_renesas_sh = 0x40
>>> + DW_CC_GNU_renesas_sh = 0x40,
>>> + DW_CC_GNU_borland_fastcall_i386 = 0x41
I am on a mission to ensure that all GNU extensions to DWARF are nicely
documented. So, at the very least, this needs a comment explaining the
meaning of this flag; maybe mentioning the `fastcall' attribute in GCC
(if indeed this is the same thing).
Jonas> Later on, Tom clarified that he thought that the gdb and gcc versions
Jonas> of dwarf2.h should actually be merged into a single copy, but that I
Jonas> shouldn't worry about this since the divergence started before my
Jonas> patch: http://sourceware.org/ml/gdb-patches/2009-04/msg00099.html
I've merged these now.
I think the usual approach for such merged files is that GCC is the
master copy.
Tom