This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] Avoid Obj-C test timeouts due to symbols not found
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: gdb-patches at sourceware dot org
- Cc: brobecker at adacore dot com (Joel Brobecker), jan dot kratochvil at redhat dot com (Jan Kratochvil), ratmice at gmail dot com (Matt Rice)
- Date: Tue, 29 Sep 2009 21:07:42 +0200 (CEST)
- Subject: [commit] Avoid Obj-C test timeouts due to symbols not found
I wrote:
> In this case, I agree that this change is much too risky for 7.0
> at this stage (even assuming Jan would manage to find and fix all
> ia64 regressions). In any case, ObjC has always been broken on
> ppc64 so my patch isn't even a regression fix as such (reverting
> it will get us back to testsuite runs taking 20 mins longer than
> they should, but I guess I can live with that).
>
> I'm going to revert my ObjC patch from the branch as soon as
> testing completes. However, I'll leave it in mainline for now,
> to expose it to further testing and see what comes up.
I've reverted the patch on the branch now.
To alleviate the test case timeout problem, I've committed the
following test-suite only patch that converts the timeouts
into simple test case failures. This makes the testsuite
usable again ...
Tested on ppc(64)-linux. Committed to mainline and branch.
Bye,
Ulrich
ChangeLog:
* gdb.objc/basicclass.exp: Disable pending breakpoint query.
* gdb.objc/nondebug.exp: Likewise.
Index: gdb/testsuite/gdb.objc/basicclass.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.objc/basicclass.exp,v
retrieving revision 1.10
diff -c -p -r1.10 basicclass.exp
*** gdb/testsuite/gdb.objc/basicclass.exp 3 Jan 2009 05:58:06 -0000 1.10
--- gdb/testsuite/gdb.objc/basicclass.exp 29 Sep 2009 18:24:15 -0000
*************** do_objc_tests
*** 102,107 ****
--- 102,112 ----
#
# Breakpoint tests
#
+
+ # Disable pending breakpoint query to avoid timeouts
+ # if Obj-C symbols cannot be found
+ gdb_test "set breakpoint pending off" "" "set breakpoint pending"
+
gdb_test "break doIt" \
"Breakpoint.*at.* file .*$srcfile, line.29.*" \
"breakpoint method"
Index: gdb/testsuite/gdb.objc/nondebug.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.objc/nondebug.exp,v
retrieving revision 1.6
diff -c -p -r1.6 nondebug.exp
*** gdb/testsuite/gdb.objc/nondebug.exp 3 Jan 2009 05:58:06 -0000 1.6
--- gdb/testsuite/gdb.objc/nondebug.exp 29 Sep 2009 18:24:15 -0000
*************** proc do_objc_tests {} {
*** 56,61 ****
--- 56,65 ----
do_objc_tests
+ # Disable pending breakpoint query to avoid timeouts
+ # if Obj-C symbols cannot be found
+ gdb_test "set breakpoint pending off" "" "set breakpoint pending"
+
#
# Break on multiply defined non-debuggable symbol (PR objc/1236)
#
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com