This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Speed up find_pc_section

From: Tom Tromey <tromey at redhat dot com>
To: Paul Pluzhnikov <ppluzhnikov at google dot com>
Cc: Pierre Muller <muller at ics dot u-strasbg dot fr>, Joel Brobecker <brobecker at adacore dot com>, Ulrich Weigand <Ulrich dot Weigand at de dot ibm dot com>, gdb-patches ml <gdb-patches at sourceware dot org>, Jan Kratochvil <jan dot kratochvil at redhat dot com>
Date: Fri, 11 Sep 2009 14:50:38 -0600
Subject: Re: [patch] Speed up find_pc_section
References: <8ac60eac0908201340k6b759eb5o9bb73c8f473d8785@mail.gmail.com> <200908211130.n7LBUCJc011108@d12av02.megacenter.de.ibm.com> <8ac60eac0908231548x135edf2doa04fa59a49455bcd@mail.gmail.com> <8ac60eac0908260020l4200cf84v2686a76b5858d13@mail.gmail.com> <20090909055824.GB11738@adacore.com> <8ac60eac0909101036r101263e7qd11c1a69f13008f1@mail.gmail.com> <20090910182952.GK20694@adacore.com> <8ac60eac0909101829g5384d665gdab27526fe95c27c@mail.gmail.com> <000c01ca32ac$0ca9f8b0$25fdea10$@u-strasbg.fr> <8ac60eac0909110029q1c88dcetdb644fa461fa545c@mail.gmail.com>
Reply-to: Tom Tromey <tromey at redhat dot com>

>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:

I'm finally catching up on this thread...

Paul> Perhaps I should just add a sequence number to 'struct objfile'? That
Paul> looks like it would almost give exact same ordering as what GDB used
Paul> before qsort+bsearch was introduced.

Is there some benefit to the old ordering?

I assumed that the old approach just gave the user an arbitrary
ordering, in which case any change here is no big deal.  But, if there
is a benefit to the old ordering, sure, restore it.

How stable a sort would you want?  You could just fall back to the
objfile's address.  Or is that too awful?

Tom

Follow-Ups:
- Re: [patch] Speed up find_pc_section
  - From: Paul Pluzhnikov

References:
- Re: [patch] Speed up find_pc_section
  - From: Joel Brobecker
- Re: [patch] Speed up find_pc_section
  - From: Paul Pluzhnikov
- Re: [patch] Speed up find_pc_section
  - From: Joel Brobecker
- Re: [patch] Speed up find_pc_section
  - From: Paul Pluzhnikov
- RE: [patch] Speed up find_pc_section
  - From: Pierre Muller
- Re: [patch] Speed up find_pc_section
  - From: Paul Pluzhnikov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]