This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Speed up find_pc_section

From: Paul Pluzhnikov <ppluzhnikov at google dot com>
To: Pierre Muller <muller at ics dot u-strasbg dot fr>
Cc: Joel Brobecker <brobecker at adacore dot com>, Ulrich Weigand <Ulrich dot Weigand at de dot ibm dot com>, gdb-patches ml <gdb-patches at sourceware dot org>, Tom Tromey <tromey at redhat dot com>, Jan Kratochvil <jan dot kratochvil at redhat dot com>
Date: Fri, 11 Sep 2009 01:03:01 -0700
Subject: Re: [patch] Speed up find_pc_section
References: <8ac60eac0908201340k6b759eb5o9bb73c8f473d8785@mail.gmail.com> <8ac60eac0908231548x135edf2doa04fa59a49455bcd@mail.gmail.com> <8ac60eac0908260020l4200cf84v2686a76b5858d13@mail.gmail.com> <20090909055824.GB11738@adacore.com> <8ac60eac0909101036r101263e7qd11c1a69f13008f1@mail.gmail.com> <20090910182952.GK20694@adacore.com> <8ac60eac0909101829g5384d665gdab27526fe95c27c@mail.gmail.com> <000c01ca32ac$0ca9f8b0$25fdea10$@u-strasbg.fr> <8ac60eac0909110029q1c88dcetdb644fa461fa545c@mail.gmail.com> <000f01ca32b3$0e6b5390$2b41fab0$@u-strasbg.fr>

On Fri, Sep 11, 2009 at 12:39 AM, Pierre Muller <muller@ics.u-strasbg.fr> wrote:

>> All overlaps are removed in filter_overlapping_sections, before the
>> first binary search is performed.
>
> ?This is where I get lost:
> I see no code in filter_overlapping_sections
> that changes map_size, so how are these overlapping
> elements removed and what is put in their place?

Ah, that's a bug; thanks for catching it.
The filter_overlapping_sections was supposed to return 'j', not 'map_size'.

I'll retest an updated patch and send it in tomorrow.
-- 
Paul Pluzhnikov

Follow-Ups:
- RE: [patch] Speed up find_pc_section
  - From: Pierre Muller

References:
- Re: [patch] Speed up find_pc_section
  - From: Joel Brobecker
- Re: [patch] Speed up find_pc_section
  - From: Paul Pluzhnikov
- Re: [patch] Speed up find_pc_section
  - From: Joel Brobecker
- Re: [patch] Speed up find_pc_section
  - From: Paul Pluzhnikov
- RE: [patch] Speed up find_pc_section
  - From: Pierre Muller
- Re: [patch] Speed up find_pc_section
  - From: Paul Pluzhnikov
- RE: [patch] Speed up find_pc_section
  - From: Pierre Muller

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]