This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: SPARC GDB Failure


On Mon, 07 Sep 2009 19:44:03 +0200, Doug Evans wrote:
> The patch is fine with me.

Checked-in.


> I think, though, the changelog shouldn't claim it fixes something
> unless that's been verified.

I agree, fixed.


Thanks,
Jan


http://sourceware.org/ml/gdb-cvs/2009-09/msg00028.html

--- src/gdb/ChangeLog	2009/09/07 11:09:33	1.10846
+++ src/gdb/ChangeLog	2009/09/07 17:52:38	1.10847
@@ -1,3 +1,9 @@
+2009-09-07  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	* m68k-tdep.c (m68k_gdbarch_init): Allocate TDEP as cleared.
+	* sparc-tdep.c (sparc32_gdbarch_init): Allocate TDEP as cleared.
+	Remove explicit clearing of TDEP fields.
+
 2009-09-06  Hui Zhu  <teawater@gmail.com>
 
 	* i386-tdep.c (i386_record_check_override): Deleted.
--- src/gdb/m68k-tdep.c	2009/07/02 17:25:55	1.144
+++ src/gdb/m68k-tdep.c	2009/09/07 17:52:41	1.145
@@ -1160,7 +1160,7 @@
       break;
     }
 
-  tdep = xmalloc (sizeof (struct gdbarch_tdep));
+  tdep = xzalloc (sizeof (struct gdbarch_tdep));
   gdbarch = gdbarch_alloc (&info, tdep);
   tdep->fpregs_present = has_fp;
   tdep->flavour = flavour;
--- src/gdb/sparc-tdep.c	2009/07/02 17:25:58	1.208
+++ src/gdb/sparc-tdep.c	2009/09/07 17:52:41	1.209
@@ -1377,16 +1377,11 @@
     return arches->gdbarch;
 
   /* Allocate space for the new architecture.  */
-  tdep = XMALLOC (struct gdbarch_tdep);
+  tdep = XZALLOC (struct gdbarch_tdep);
   gdbarch = gdbarch_alloc (&info, tdep);
 
   tdep->pc_regnum = SPARC32_PC_REGNUM;
   tdep->npc_regnum = SPARC32_NPC_REGNUM;
-  tdep->gregset = NULL;
-  tdep->sizeof_gregset = 0;
-  tdep->fpregset = NULL;
-  tdep->sizeof_fpregset = 0;
-  tdep->plt_entry_size = 0;
   tdep->step_trap = sparc_step_trap;
 
   set_gdbarch_long_double_bit (gdbarch, 128);


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]