This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFC: DW_OP_call_frame_cfa, again
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org, Tom Tromey <tromey at redhat dot com>
- Date: Wed, 2 Sep 2009 00:23:56 +0100
- Subject: Re: RFC: DW_OP_call_frame_cfa, again
- References: <m37hxauldt.fsf@fleche.redhat.com> <m3skf6tu5i.fsf@fleche.redhat.com>
On Tuesday 01 September 2009 19:08:25, Tom Tromey wrote:
>
> +/* CFA accesses require a frame. */
> +static CORE_ADDR
> +needs_frame_frame_cfa (void *baton)
> +{
> + struct needs_frame_baton *nf_baton = baton;
> + nf_baton->needs_frame = 1;
> + return 1;
> +}
> +
Return type is CORE_ADDR, but it returns 1?
On Tuesday 01 September 2009 19:08:25, Tom Tromey wrote:
> +/* Return true if the frame unwinder for frame FI is UNWINDER; false
> + otherwise. */
> +
> +extern int frame_unwinder_is (struct frame_info *fi,
> + const struct frame_unwind *unwinder);
> +/* Return true if the frame base for frame FI is BASE; false
> + otherwise. */
> +
> +int
> +frame_unwinder_is (struct frame_info *fi, const struct frame_unwind *unwinder)
> +{
Stale comment.
--
Pedro Alves