Re: [RFA] Fix too many "no debugging symbols found" warnings.

[Doug Evans <dje at google dot com>]

On Thu, Aug 27, 2009 at 11:28 AM, Tom Tromey<tromey@redhat.com> wrote:
>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>
> Tom> This particular function seems overdue for ui-out-ification.
> Tom> This would let us keep the old version for MI[12], and then properly
> Tom> evolve the output for future versions MI.
>
> Doug> Is this what you had in mind?
>
> Yes, thanks.
>
> FWIW that was just a drive-by complaint of mine... I will try to stop
> doing that, I didn't intend to get you to do this.
>
> Doug> + ?ui_out_table_header (uiout, addr_width - 1, ui_left, "From", "From");
> Doug> + ?ui_out_table_header (uiout, addr_width - 1, ui_left, "To", "To");
> Doug> + ?ui_out_table_header (uiout, 12 - 1, ui_left, "SymsRead", "Syms Read");
>
> It seems to be GDB style that column names (the first string arg) should
> be lowercase, not camelcase. ?Generally they use "-" and not "_" as well
> (I only saw one exception).
>
> Doug> + ? ui_out_field_string (uiout, "From", "");
> Doug> + ? ui_out_field_string (uiout, "To", "");
>
> Probably use ui_out_field_skip here.
>
> Tom
>

Thanks for the review.

I made the suggested changes (including Eli's) and checked it in.

I tested it with Eclipse, btw.
It does parse the output of "info sharedlibrary" and doesn't like "Yes (*)",
so I made the changed output conditional on the top level interpreter
not being MI.
I think we'll want to add a new MI command for this for Eclipse, etc. to use.

[P.S. the "doc/" in the attached changelog entry is just my convention.
It doesn't appear in doc/ChangeLog.]

2009-08-27  Doug Evans  <dje@google.com>

        * NEWS: Add note on "info sharedlibrary".
        Remove note on "set print symbol-loading".
        * main.c (captured_main): Pass !batch for from_tty when calling
        symbol_file_add_main.
        * objfiles.h (objfile_has_partial_symbols): Declare.
        (objfile_has_full_symbols): Declare.
        * objfiles.c (objfile_has_partial_symbols): New function.
        (have_partial_symbols): Use it.
        (objfile_has_full_symbols): New function.
        (have_full_symbols): Use it.
        * solib.c: Include interps.h.
        (solib_read_symbols): Back out patch of 2008-07-10.
        Add test for info_verbose for symbol loading messages for
        consistency with symfile.c.
        (info_sharedlibrary_command): Handle optional parameter of regex of
        libraries to list.  Inform user of libraries without debugging info.
        Rewrite to use ui_out routines to format output.
        * symfile.c (print_symbol_loading): Delete.
        (symbol_file_add_with_addrs_or_offsets): Back out patch of 2008-07-10.
        Print "no debugging symbols found" only if from_tty || info_verbose;
        and only check file being loaded, not all files.
        (reread_symbols): Test file being loaded for whether it has symbols,
        not all files.
        (__initialize_symfile): Delete `set print symbol-loading'.
        * symfile.h (print_symbol_loading): Delete.

        * doc/gdb.texinfo (Symbols): Delete `set print symbol-loading'.
        (Files): Add note on new optional regex arg to `info sharedlibrary'.

Attachment: gdb-090827-info-shared-2.patch.txt
Description: Text document