This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Fix too many "no debugging symbols found" warnings.


>>>>> "Doug" == Doug Evans <dje@google.com> writes:

Tom> This particular function seems overdue for ui-out-ification.
Tom> This would let us keep the old version for MI[12], and then properly
Tom> evolve the output for future versions MI.

Doug> Is this what you had in mind?

Yes, thanks.

FWIW that was just a drive-by complaint of mine... I will try to stop
doing that, I didn't intend to get you to do this.

Doug> +  ui_out_table_header (uiout, addr_width - 1, ui_left, "From", "From");
Doug> +  ui_out_table_header (uiout, addr_width - 1, ui_left, "To", "To");
Doug> +  ui_out_table_header (uiout, 12 - 1, ui_left, "SymsRead", "Syms Read");

It seems to be GDB style that column names (the first string arg) should
be lowercase, not camelcase.  Generally they use "-" and not "_" as well
(I only saw one exception).

Doug> +	  ui_out_field_string (uiout, "From", "");
Doug> +	  ui_out_field_string (uiout, "To", "");

Probably use ui_out_field_skip here.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]