Re: [patch] Speed up find_pc_section

[Paul Pluzhnikov <ppluzhnikov at google dot com>]

On Thu, Aug 20, 2009 at 11:22 AM, Ulrich Weigand<uweigand@de.ibm.com> wrote:

> Unfortunately, this doesn't help. ...
> If you want to remove *all* overlay sections, mapped or not, you

Yes.

> could attempt to use "section_is_overlay" instead. ?But that won't
> work either -- all the overlay routines have a shortcut that says
> "no" to all such questions before the user actually enabled overlay
> support. ?This means that when loading a binary with overlays,
> you still crash at the assertion before the user even has the
> chance to give the "overlay auto" command.

Right. Here is an updated patch ...

> It used to be the case that you could debug -to some extent- binaries
> with overlays even in "overlay off" mode, e.g. because GDB does not
> support the particular overlay manager. ?I think this should be preserved;
> at least GDB should not run into assertion failures just because section
> addresses overlap ...

I believe the crash at load should be gone now, and some debugging will
be possible, though find_pc_section will fail to find any overlay section
which find_pc_mapped_section doesn't find. I think that's still better
than what GDB was doing before under these conditions: finding a "random"
overlapping overlay section.

Thanks,
-- 
Paul Pluzhnikov

2009-08-20  Paul Pluzhnikov  <ppluzhnikov@google.com>

	*objfiles.c (insert_section_p): New function.
	(update_section_map): Call it.

Attachment: gdb-find_pc_section-20090820-2.txt
Description: Text document