This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Bug in i386_process_record
- From: Hui Zhu <teawater at gmail dot com>
- To: Michael Snyder <msnyder at vmware dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 17 Aug 2009 00:12:16 +0800
- Subject: Re: Bug in i386_process_record
- References: <4A875C26.7060302@vmware.com>
case 0x67:
prefixes |= PREFIX_ADDR;
break;
case 0x40:
case 0x41:
case 0x42:
case 0x43:
case 0x44:
case 0x45:
case 0x46:
case 0x47:
/* inv */
case 0x40:
case 0x41:
case 0x42:
case 0x43:
case 0x44:
case 0x45:
case 0x46:
case 0x47:
Oops, I must make something wrong. I need check the spec of amd64 clear.
Thanks,
Hui
On Sun, Aug 16, 2009 at 09:08, Michael Snyder<msnyder@vmware.com> wrote:
> Hi Hui,
>
> This line in i386-tdep.c causes 4 failures in machinestate.exp.
>
> diff -u -p -r1.283 i386-tdep.c
> --- i386-tdep.c 10 Aug 2009 03:02:39 -0000 ? ? ?1.283
> +++ i386-tdep.c 16 Aug 2009 01:07:48 -0000
> @@ -3283,7 +3283,7 @@ i386_process_record (struct gdbarch *gdb
> ? ? ? ? case 0x40:
> ? ? ? ? case 0x41:
> ? ? ? ? case 0x42:
> - ? ? ? ?case 0x43:
> + ? ? ? ? // ? ? ? ?case 0x43:
> ? ? ? ? case 0x44:
> ? ? ? ? case 0x45:
> ? ? ? ? case 0x46:
>
> 0x43 is "inc %ebx", and this line causes it to be treated as a prefix,
> consuming the instruction without recording the register change.
>
> I don't want to change it myself, because I'm not sure what other
> side effects the change might have. ?Could you fix it please? ?;-)
>
> Thanks,
> Michael
>
>