This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Fix Darwin breakage
- From: Paul Pluzhnikov <ppluzhnikov at google dot com>
- To: gdb-patches ml <gdb-patches at sourceware dot org>
- Cc: Christian Thalinger <Christian dot Thalinger at sun dot com>, Paul Pluzhnikov <ppluzhnikov at google dot com>
- Date: Fri, 14 Aug 2009 10:38:44 -0700
- Subject: Re: [patch] Fix Darwin breakage
- References: <8ac60eac0908140922m57367e9dn464783d8ff625474@mail.gmail.com>
On Fri, Aug 14, 2009 at 9:22 AM, Paul Pluzhnikov<ppluzhnikov@google.com> wrote:
> Here is a proposed fix.
I just realized that I should probably also turn OBJF_NOT_MAPPED
for separate debuginfo files like this:
Index: symfile.c
===================================================================
RCS file: /cvs/src/src/gdb/symfile.c,v
retrieving revision 1.241
diff -u -p -u -r1.241 symfile.c
--- symfile.c 10 Aug 2009 22:09:22 -0000 1.241
+++ symfile.c 14 Aug 2009 17:32:33 -0000
@@ -2534,8 +2534,9 @@ reread_separate_symbols (struct objfile
info_verbose ? SYMFILE_VERBOSE : 0,
0, /* No addr table. */
objfile->section_offsets, objfile->num_sections,
- objfile->flags & (OBJF_REORDERED | OBJF_SHARED | OBJF_READNOW
- | OBJF_USERLOADED)));
+ (objfile->flags & (OBJF_REORDERED | OBJF_SHARED | OBJF_READNOW
+ | OBJF_USERLOADED)
+ | OBJF_NOT_MAPPED));
objfile->separate_debug_objfile->separate_debug_objfile_backlink
= objfile;
}
so I don't have to sort/eliminate duplicates later in objfiles.c
update_section_map, and audit other places (if any) where
symbol_file_add* routines are called as well.
I'll do that, if the initial patch is deemed roughly correct.
Thanks,
--
Paul Pluzhnikov