This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Speed up find_pc_section

From: Paul Pluzhnikov <ppluzhnikov at google dot com>
To: Tom Tromey <tromey at redhat dot com>
Cc: gdb-patches ml <gdb-patches at sourceware dot org>
Date: Sat, 8 Aug 2009 11:08:38 -0700
Subject: Re: [patch] Speed up find_pc_section
References: <8ac60eac0907161724v40e5bd8bg7877d8901b8d7b6e@mail.gmail.com> <8ac60eac0908040806g4f0495f6gc24ae4d6e440e7e6@mail.gmail.com> <m3zlaffv3h.fsf@fleche.redhat.com> <8ac60eac0908042358q4d2061d2md3c49cf4aab26398@mail.gmail.com> <m34osmi5jx.fsf@fleche.redhat.com> <8ac60eac0908050940we3dc478rd182f4367a650f1b@mail.gmail.com> <8ac60eac0908052259l7b1c21d1t212991886a5f8b18@mail.gmail.com> <m3eirofxwh.fsf@fleche.redhat.com> <8ac60eac0908070030g7500a5ack3fcc81862e2a5b0a@mail.gmail.com> <8ac60eac0908071529j5be2241bjf7fac5cbf55168a9@mail.gmail.com>

On Fri, Aug 7, 2009 at 3:29 PM, Paul Pluzhnikov<ppluzhnikov@google.com> wrote:

> I was able to reproduce the failed assert on F11/i586, but only after the
> system ran for a while.

Update: running 'make check' on F11 after prelinking shows many
similar failures. The "java setup" in Tom's repro instructions doesn't
appear necessary.

Here is a fix. Tested on F11/i586 (with prelinking) and Linux/x86_64 (without).

Thanks,
-- 
Paul Pluzhnikov

2009-08-08  Paul Pluzhnikov  <ppluzhnikov@google.com>

        * objfiles.c (qsort_cmp): Remove assert.
        (preferred_obj_section): New function.
        (update_section_map): Filter duplicates.

Attachment: gdb-find_pc_section-20090808.txt
Description: Text document

Follow-Ups:
- Re: [patch] Speed up find_pc_section
  - From: Tom Tromey
- Re: [patch] Speed up find_pc_section
  - From: Ulrich Weigand

References:
- Re: [patch] Speed up find_pc_section
  - From: Paul Pluzhnikov
- Re: [patch] Speed up find_pc_section
  - From: Tom Tromey
- Re: [patch] Speed up find_pc_section
  - From: Paul Pluzhnikov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]