This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] small change for better error reporting in remote.c
- From: "drow at false dot org" <drow at false dot org>
- To: Michael Snyder <msnyder at vmware dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 30 Jul 2009 17:30:19 -0400
- Subject: Re: [RFC] small change for better error reporting in remote.c
- References: <4A70E268.6010401@vmware.com>
On Wed, Jul 29, 2009 at 04:59:36PM -0700, Michael Snyder wrote:
> @@ -5189,7 +5192,10 @@ store_registers_using_G (const struct re
> /* remote_prepare_to_store insures that rsa->sizeof_g_packet gets
> updated. */
> bin2hex (regs, p, rsa->sizeof_g_packet);
> - remote_send (&rs->buf, &rs->buf_size);
> + putpkt (rs->buf);
> + getpkt (&rs->buf, &rs->buf_size, 0);
> + if (rs->buf[0] == 'E')
> + error (_("Could not write registers"));
> }
>
> /* Store register REGNUM, or all registers if REGNUM == -1, from the contents
Can't you use packet_ok like elsewhere? Otherwise OK.
--
Daniel Jacobowitz
CodeSourcery