This is the mail archive of the
mailing list for the GDB project.
Re: i386.record.floating.point.patch : with more testing and assurity
- From: Michael Snyder <msnyder at vmware dot com>
- To: paawan oza <paawan1982 at yahoo dot com>
- Cc: Hui Zhu <teawater at gmail dot com>, Mark Kettenis <mark dot kettenis at xs4all dot nl>, "pedro at codesourcery dot com" <pedro at codesourcery dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Sun, 26 Jul 2009 12:03:37 -0700
- Subject: Re: i386.record.floating.point.patch : with more testing and assurity
- References: <email@example.com>
paawan oza wrote:
I have worked on formatting part of the patch as per Michael and Hui's comments.
there is one problem I have been observing.
when I edit with emac and make everything correct....
still the command 'diff -bwEurN' gives some unaligned formatting at some lines.
Unfortunately, the formatting (indent) issues are confusing:
1) Some are artifacts of the combination of spaces and tabs.
These can be ignored.
2) But some are still mis-indentations. I'll point some out.
but now things are much improved as far as far as formatting is concerned.
please find the files attached.
1) i386-tdep.c : this looks perfectly okay as per comments and formatting as per open source standard.
Well, much closer anyway. ;-)
2) i386-tdep.orig.c : original file.
And here's another issue. Your "orig" file is only up to date
as of July 9. There have been several cvs changes since then.
You need to always update and merge your files before submitting a diff.
3) patch : when you edit this patch it has still some formatting problem
, but when you apply on linux, the resulting file looks okay.
please extract the attached package, you will find above contents
when I take the patch on windows and try to mail,
again format changes....and I have no clue (I tried to remove tabs, dos2unix etc....)
but still it is the same....
(please try take difference with attached files and see the 'diff' result, it is strange, if you take the patch on windows it gets even more worse with formatting)
please let me know where and how can I take the difference between new and original file (attached with mail)....
Have you tried doing your diffs and your email from a linux machine?
I'll send diff comments in a separate email.