Re: [RFA] clean up temp sals in handle_inferior_event

[Stan Shebs <stan at codesourcery dot com>]

Tom Tromey wrote:
> > > > > > "Michael" == Michael Snyder <msnyder@vmware.com> writes:
> > > > > >             
>
> Michael> There were seven, and now eight, places in handle_inferior_event
> Michael> where a local struct symtab_and_line is declared and used briefly.
> Michael> One of them even opens and closes a block just for this purpose.
>
> Michael> This patch merges those all into a single local temp variable.
>
> Michael> They all initialize it, and all but one of them returns after
> Michael> using it, so they can't interact.  Plus I ran the testsuites
> Michael> with no regressions.
>
> I find the old code clearer.  In the old code, these temporary variables
> are mostly declared in small blocks surrounding their point of use.
> This means that it is very easy to reason about the variable: its entire
> lifetime fits onto the screen at once.
>   
I'd find it easier debuggingwise to have fewer of the small scopes, 
*but* to give the sals different names indicating their roles.  For me 
the confusion comes from using a single variable name in a function to 
mean several different things, whether or not each is in a different scope.

Stan