This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Restore GNU/Hurd functionality (was: Modernize solaris threads support.)


On Tue, Feb 24, 2009 at 02:38:58PM +0000, Pedro Alves wrote:
> On Tuesday 24 February 2009 14:33:05, Pierre Muller wrote:
> > Pedro, 
> > you also broke windows-nat.c compilation...
> Uh!  Darn it.  [...]

... and another one (which I noticed only now...): when we recently got a
new Debian gdb package, all attempts to use GDB on GNU/Hurd started
failing like this:

    $ gdb /bin/true
    GNU gdb (GDB)
    Copyright (C) 2009 Free Software Foundation, Inc.
    (no debugging symbols found)
    (gdb) r
    Starting program: /bin/true 
    Segmentation fault

> In any case, as I said before, I had to touch most *native*
> configurations, so it's likelly that I missed several cases.  If
> you do spot one, the fix is *dead trivial*, so go ahead and commit a
> fix as obvious ...

You did change the ``extern gnu_store_registers'' and ``extern
gnu_fetch_registers'' declarations in gnu-nat.c, but not their definitons
in i386gnu-nat.c, which I have committed now (as obvious).  Should we
perhaps move these two declarations into a file that is #included from
i386gnu-nat.c?  gnu-nat.h perhaps?

Index: ChangeLog
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.10725
diff -u -p -r1.10725 ChangeLog
--- ChangeLog	18 Jul 2009 23:35:30 -0000	1.10725
+++ ChangeLog	20 Jul 2009 09:50:16 -0000
@@ -1,3 +1,8 @@
+2009-07-20  Thomas Schwinge  <>
+	* i386gnu-nat.c (gnu_fetch_registers, gnu_store_registers): Adjust to
+	2009-02-23 target_ops changes.
 2009-07-18  Michael Snyder  <>
 	* infrun.c (handle_inferior_event): Remove an execution_direction
Index: i386gnu-nat.c
RCS file: /cvs/src/src/gdb/i386gnu-nat.c,v
retrieving revision 1.36
diff -u -p -r1.36 i386gnu-nat.c
--- i386gnu-nat.c	3 Jan 2009 05:57:52 -0000	1.36
+++ i386gnu-nat.c	20 Jul 2009 09:50:16 -0000
@@ -111,7 +111,8 @@ supply_fpregset (struct regcache *regcac
 /* Fetch register REGNO, or all regs if REGNO is -1.  */
-gnu_fetch_registers (struct regcache *regcache, int regno)
+gnu_fetch_registers (struct target_ops *ops,
+		     struct regcache *regcache, int regno)
   struct proc *thread;
@@ -202,7 +203,8 @@ store_fpregs (const struct regcache *reg
 /* Store at least register REGNO, or all regs if REGNO == -1.  */
-gnu_store_registers (struct regcache *regcache, int regno)
+gnu_store_registers (struct target_ops *ops,
+		     struct regcache *regcache, int regno)
   struct proc *thread;
   struct gdbarch *gdbarch = get_regcache_arch (regcache);


Attachment: signature.asc
Description: Digital signature

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]