This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix double free
- From: Doug Evans <dje at google dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 17 Jul 2009 20:08:20 -0700
- Subject: Re: [RFA] Fix double free
- References: <4A610157.10201@redhat.com>
On Fri, Jul 17, 2009 at 3:55 PM, Keith Seitz<keiths@redhat.com> wrote:
> Hi,
>
> An insight user (yes, there are still a few of us ;-) noticed that insight
> would crash when using gdb's "search" command. Turns out this is a simple
> cleanup buglet. I think it is easier to read the patch than explain, so I'll
> leave it at that.
>
> Ok?
> Keith
>
> ChangeLog
> 2009-07-17 ?Keith Seitz ?<keiths@redhat.com>
>
> ? ? ? ?* source.c (forward_search_command): Don't fclose the stream,
> ? ? ? ?just run the cleanups.
Hi.
Looks right to me.
The problem occurs twice in reverse_search_command as well.