This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] gdbserver: Add qnx target

On Monday 06 July 2009 17:01:26, Aleksandar Ristovski wrote:
> Pedro Alves wrote:

> > Are ldd.c's sources available?  :-)  If not, could you paste
> > that comment there too?
> Comment from ldd.c pasted.

Thank you!  Looks nicer now.

> > On Wednesday 24 June 2009 19:50:39, Aleksandar Ristovski wrote
> >> +  i[34567]86-*-nto*)   srv_regobj=reg-i386.o
> >> +                       srv_tgtobj="nto-low.o nto-x86-low.o"
> >> +                       srv_qnx_LIBS=-lsocket
> >> +                       srv_qnx="yes"
> > 
> > Do you think the set of libs will change depending on the qnx
> > arch?  In other words, if you're adding a $srv_qnx, do you really
> > need a new srv_qnx_LIBS variable?
> Unlikely. I just thought it was nicer. But in this patch I 
> removed it and -lsocket is now "hard-coded" in 

Thanks.  I think that either your original patch (which I had
okayed), or the new one is fine --- while that version was middle
ground without the benefits of either.

> nto_inferior.exit_signo. Current code in nto-procfs.c 
> doesn't do that but it's a bug that results gdb reporting 
> "program exited normally" after program dies due to 
> unhandled signal.

Yeah.  You just might find out that the suggestion I had
given before would fix this cleanly.  :-)

> ChangeLog:
> 	Adding Neutrino gdbserver.
> 	* configure: Regenerated.
> 	* Add case for srv_qnx and set LIBS 
> accordingly..

              ^ spurious '.'

> 	* configure.srv (i[34567]86-*-nto*): New target.
> 	* nto-low.c, nto-low.h, nto-x86-low.c: New files.
> 	* remote-utils.c [__QNX__]: Include sys/iomgr.h

                                                       ^ missing '.'

> 	(nto_comctrl) [__QNX__]: New function.
> 	(enable_async_io, disable_async_io) [__QNX__]: Call 
> nto_comctrl.

Ok.  Please commit.

Pedro Alves

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]