This is the mail archive of the
mailing list for the GDB project.
Re: i386.record.floating.point.patch : with more testing and assurity
- From: paawan oza <paawan1982 at yahoo dot com>
- To: Michael Snyder <msnyder at vmware dot com>
- Cc: Mark Kettenis <mark dot kettenis at xs4all dot nl>, "pedro at codesourcery dot com" <pedro at codesourcery dot com>, "teawater at gmail dot com" <teawater at gmail dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 3 Jul 2009 22:19:12 -0700 (PDT)
- Subject: Re: i386.record.floating.point.patch : with more testing and assurity
Actually, the initial patch which I submitted were using them.
but as I have incorporated Hui's comments I have removed those constants completely.
in the sense I have no longer extended the enumration.
but of course, those registers are recorded as and when required.
e.g. (ffree insn changes FTAG register, so we record it)
--- On Sat, 7/4/09, Michael Snyder <firstname.lastname@example.org> wrote:
> From: Michael Snyder <email@example.com>
> Subject: Re: i386.record.floating.point.patch : with more testing and assurity
> To: "paawan oza" <firstname.lastname@example.org>
> Cc: "Mark Kettenis" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>
> Date: Saturday, July 4, 2009, 3:19 AM
> paawan oza wrote:
> > Hi,
> > In My understanding the point was like below.
> > in the patch there were following register extended in
> enumeration in i386-tdep.h
> > I386_FSTAT,
> > I386_FTAG,? ? ???I386_FISEG,
> > I386_FIOFF,
> > I386_FOSEG,
> > I386_FOOFF,
> > I386_FOP
> > According to Hui in some of his previous mails...his
> idea was
> >> FCTRL, FOP and so on are the fp reg of
> amd64.? For now, prec is still
> >> not support amd64 And amd64's support are in
> amd64-tedp.... files.? >Change i386_regnum is not a
> good idea. I suggest you divide fp patch to 2 >parts. One
> is for i386, the other for amd64. For now, just send i386
> patch >for review.? And send amd64 patch when prec
> support amd64"
> > while, my idea/understanding is:
> > FCTRL, FOP registers are not only a part of amd64, but
> also part of i386 (x87 FPU unit) also.
> > so according to me these registers are part of i386
> also and it needed to be also in i386-tdep.h.
> > Regards,
> > Oza.
> I'm not sure why you want to add those constants to
> when the rest of your patch does not seem to use them.