This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 4/8] Types GC [varobj_list to all_root_varobjs]

On Tue, 09 Jun 2009 22:50:42 +0200, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <> writes:
> Jan> I find the callback based iterator easier to use,
> It seems reasonable to me, though it would be nice to have Volodya's
> approval.

Is it OK to check it in, Vladimir?  The patch would go in unchanged:

Regression re-tested now on {x86_64,i686}-fedora-linux-gnu.

> Jan> in fact there were bugs due to the
> Jan> current calling semantics (`floating' lockup, memory leaks).
> Details on the bugs that this fixes would be nice.
> A test case would also be nice, assuming these are testable.

The `floating' lockup will get fixed by a later patch using this new
all_root_varobjs function.   A testcase for it was in a now-obsolete patch:
	[patch] Fix gdb.mi hang on floating VAROBJs
This patch itself still does not fix it.

The (small) memory caused by the current semantics you fixed by:
	RFA: fix PR 9350


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]