This is the mail archive of the
mailing list for the GDB project.
Re: i386.record.floating.point.patch : with more testing and assurity
- From: paawan oza <paawan1982 at yahoo dot com>
- To: gdb-patches at sourceware dot org, Pedro Alves <pedro at codesourcery dot com>
- Cc: teawater at gmail dot com
- Date: Tue, 30 Jun 2009 08:05:46 -0700 (PDT)
- Subject: Re: i386.record.floating.point.patch : with more testing and assurity
As I am submitting the patch for the first time, I am not much aware of gdb test suite.
would you please guide me about how I can put the things in the testsuite ?
is it the testsuite which comes along with the gdb source ?
--- On Tue, 6/30/09, Pedro Alves <firstname.lastname@example.org> wrote:
> From: Pedro Alves <email@example.com>
> Subject: Re: i386.record.floating.point.patch : with more testing and assurity
> To: firstname.lastname@example.org
> Cc: "paawan oza" <email@example.com>, firstname.lastname@example.org
> Date: Tuesday, June 30, 2009, 7:09 PM
> On Tuesday 30 June 2009 14:23:30,
> paawan oza wrote:
> > > As suggested by Hui,
> > > I have come up with more detailed and granular
> test case
> > > for the patch which I had submitted last week.
> Could you please consider migrating that test into the
> You've gone through the trouble of writing tests to make
> the features work now --- putting it in the testsuite means
> have an automatic-ish means to check that it doesn't get
> inadvertently broken in the future.? The way it is,
> when your
> code gets in, the test will probably end up lost in the
> We wouldn't want that, would we?? :-)? Having
> auto-tests, also helps
> the person doing the review in confirming things work as
> expected (without much effort).
> Pedro Alves