This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: i386.record.floating.point.patch : with more testing and assurity

As I am submitting the patch for the first time, I am not much aware of gdb test suite.
would you please guide me about how I can put the things in the testsuite ?
is it the testsuite which comes along with the gdb source ?
gdb\testsuite\gdb.base ??

--- On Tue, 6/30/09, Pedro Alves <> wrote:

> From: Pedro Alves <>
> Subject: Re: i386.record.floating.point.patch : with more testing and assurity
> To:
> Cc: "paawan oza" <>,
> Date: Tuesday, June 30, 2009, 7:09 PM
> On Tuesday 30 June 2009 14:23:30,
> paawan oza wrote:
> > 
> > > As suggested by Hui, 
> > > I have come up with more detailed and granular
> test case
> > > for the patch which I had submitted last week.
> Could you please consider migrating that test into the
> testsuite?
> You've gone through the trouble of writing tests to make
> sure
> the features work now --- putting it in the testsuite means
> we
> have an automatic-ish means to check that it doesn't get
> inadvertently broken in the future.? The way it is,
> when your
> code gets in, the test will probably end up lost in the
> archives.
> We wouldn't want that, would we?? :-)? Having
> auto-tests, also helps
> the person doing the review in confirming things work as
> expected (without much effort).
> -- 
> Pedro Alves

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]