This is the mail archive of the
mailing list for the GDB project.
Re: [patch] Fix i386 memory-by-register access on amd64
- From: Tom Tromey <tromey at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: Mark Kettenis <mark dot kettenis at xs4all dot nl>, gdb-patches at sourceware dot org
- Date: Thu, 25 Jun 2009 10:33:43 -0600
- Subject: Re: [patch] Fix i386 memory-by-register access on amd64
- References: <20090429102719.GA10117@host0.dyn.jankratochvil.net> <200904291904.n3TJ4X7m000790@brahms.sibelius.xs4all.nl> <20090429202916.GA21831@host0.dyn.jankratochvil.net>
- Reply-to: tromey at redhat dot com
>>>>> "Jan" == Jan Kratochvil <firstname.lastname@example.org> writes:
Resurrecting an oldish thread.
Jan> While not trying to judge what is right or wrong:
Jan> I believe gdb.x86_64 debugging gdb.i386 inferior should behave exactly as
Jan> gdb.i386 debugging gdb.i386 inferior.
This sounds reasonable to me. If I'm debugging a 32-bit inferior, it
seems weird to see a 64-bit address.
Jan> As value_as_address is a long function with many `return'
Jan> commands. But I do not have any strong opinion on it - would you
Jan> like to fill a variable and using a single exit path which would
Jan> cut the result width?
This sounds ok to me. value_as_address is really long, true, but it
is mostly comments. There are really only 3 returns.