This is the mail archive of the
mailing list for the GDB project.
Re: [patch] Fix a reread_symbols regression by mmap [Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.]
>>>>> "Jan" == Jan Kratochvil <firstname.lastname@example.org> writes:
Jan> while sure your patch is great it has a regression. Assuming a regression
Jan> reproducer needs to link GDB with -lmcheck (but did verify it).
Thanks for finding this.
Jan> 2009-06-23 Jan Kratochvil <email@example.com>
Jan> Fix a regression by the mmap patch from 2009-06-16.
Jan> * symfile.c (reread_symbols): Move sym_finish and clear_objfile_data
Jan> calls before deleting the OBJFILE obstack. Extend the comment.
This is ok.
Jan> + Try to keep the freeing order compatible with free_objfile. */
It seems like it would be nice to have a single function here.