This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] gdbserver regcache fetch all regs

From: Daniel Jacobowitz <drow at false dot org>
To: Doug Evans <dje at google dot com>
Cc: Aleksandar Ristovski <aristovski at qnx dot com>, gdb-patches at sources dot redhat dot com
Date: Fri, 19 Jun 2009 11:55:37 -0400
Subject: Re: [patch] gdbserver regcache fetch all regs
References: <h19gl1$t66$1@ger.gmane.org> <e394668d0906190835j481d7546td6bf9b8baae9c77d@mail.gmail.com>

On Fri, Jun 19, 2009 at 08:35:13AM -0700, Doug Evans wrote:
> Hi.  At first I thought "Yikes!". :-)
> But it turns out that all fetch_registers routines treat 0 and -1 equivalently.
> I wouldn't hold up this patch (it's fine with me fwiw), though I would
> change the ChangeLog entry to something like: "Use -1 instead of 0 to
> fetch all registers." since passing 0 does actually fetch all
> registers.

Agreed on all counts.

> It would be good to remove this oddity and stop the conflation of 0
> and -1, but I don't know what would break.
> We could run the testsuite and see what happens as a start.
> Does anyone know the history behind this?

Pretty sure nothing will break - since nothing else calls these
functions.  I could be mistaken though.

-- 
Daniel Jacobowitz
CodeSourcery

Follow-Ups:
- Re: [patch] gdbserver regcache fetch all regs
  - From: Aleksandar Ristovski

References:
- [patch] gdbserver regcache fetch all regs
  - From: Aleksandar Ristovski
- Re: [patch] gdbserver regcache fetch all regs
  - From: Doug Evans

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]