This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Eliminate quadratic slow-down on number of solibs (take 2).
>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:
Paul> 2009-06-15 Paul Pluzhnikov <ppluzhnikov@google.com>
Paul> * solib.c (symbol_add_stub): New FLAGS parameter.
[...]
Just two nits.
Paul> +enum symfile_add_flags
Paul> + {
Paul> + SYMFILE_VERBOSE = 1 << 1,
Paul> + SYMFILE_MAINLINE = 1 << 2,
Paul> + SYMFILE_DEFER_BP_RESET = 1 << 3
Paul> + };
This needs a comment before the enum, and ideally also a comment
explaining each constant.
Paul> Index: windows-nat.c
[...]
Paul> + const int add_flags = (p->from_tty ? SYMFILE_VERBOSE : 0)
Paul> + | (p->mainline ? SYMFILE_MAINLINE : 0);
This needs parens around the whole RHS, and the continuation line
should be indented.
Ok with these changes. Thanks for persevering.
Tom