This is the mail archive of the
mailing list for the GDB project.
Re: ptid from core section
On Wednesday 03 June 2009 17:59:21, Aleksandar Ristovski wrote:
> > It would be nice if you included the nto bits in the
> > patch, so we can see how this helps in your case, so
> > that people can check upfront if this change is
> > sufficient and good.
> oops... and you couldn't guess??? :-D
The rumours that I'm clairvoyant are really just rumours. :-)
> ????????* sol2-tdep.h (sol2_ptid_from_core_section,
> ????????sol2_core_section_name_from_ptid): New declarations.
Please line wrap these cases like:
* sol2-tdep.h (sol2_ptid_from_core_section)
(sol2_core_section_name_from_ptid): New declarations.
Thanks. Don't forget to add something like this to the changelog:
* gdbarch.h, gdbarch.c: Regenerate.
This is mostly OK as far as I'm concerned. One question though:
> (ptid_from_core_section, core_section_name_from_ptid): New
Is there still a reason the former takes bfd and bfd section pointers,
instead of being a mirror of the latter (say, ptid_from_core_section_name)?