This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] fix break-always test

Pedro Alves wrote:
On Saturday 30 May 2009 00:41:53, Michael Snyder wrote:
"set breakpoint always" does not accept "1", it wants "on".

(gdb) set breakpoint always-inserted 1 Undefined item: "1". (gdb) PASS: gdb.base/break-always.exp: set breakpoint always-inserted 1

Outch, this used to work, until set breakpoint always-inserted
was made into a three-state.  Yikes, this has been broken for months.
My fault, as usual.  :-)

2009-05-29 Michael Snyder <>

* gdb.base/break-always.exp: Change "1" to "on".

This is certainly OK.

It would be a nice improvent to make the test confirm that
the mode is in effect, perhaps by just reading back the
> setting with "show breakpoint always-inserted".

Good idea, implemented and checked in as below.

2009-05-29  Michael Snyder  <>

	* gdb.base/break-always.exp: Change "1" to "on".
	Add confirmation check.

Index: gdb.base/break-always.exp
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/break-always.exp,v
retrieving revision 1.2
diff -d -u -r1.2 break-always.exp
--- gdb.base/break-always.exp	3 Jan 2009 05:58:03 -0000	1.2
+++ gdb.base/break-always.exp	1 Jun 2009 19:18:59 -0000
@@ -21,7 +21,10 @@
 set bar_location [gdb_get_line_number "break in bar" break-always.c]
-gdb_test "set breakpoint always-inserted 1" ""
+gdb_test "set breakpoint always-inserted on" ""
+gdb_test "show breakpoint always-inserted" "mode is on\." \
+    "confirm breakpoint always-inserted"
 runto foo

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]