This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.

From: Tom Tromey <tromey at redhat dot com>
To: Paul Pluzhnikov <ppluzhnikov at google dot com>
Cc: gdb-patches at sources dot redhat dot com
Date: Sat, 30 May 2009 16:36:12 -0600
Subject: Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
References: <20090527001157.934BD76BC0@localhost> <m3iqjmt4bn.fsf@fleche.redhat.com> <8ac60eac0905280956v79d9a84apad9a4370212283b9@mail.gmail.com>
Reply-to: Tom Tromey <tromey at redhat dot com>

>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:

Tom> It has a number of minor formatting problems, mostly missing spaces
Tom> before open parens.

Paul> Sorry, these get me every time :-(

Yeah.  Whatever happened to running gdb_indent.sh?

Paul> I would have used bfd_get_file_window(), but it's only compiled in
Paul> when --use-mmap was given to bfd/configure.
Paul> Is there a way to turn that on for GDB?

Paul> Is it ok to do this in gdb/dwarf2read.c:
Paul>   if (info->size > 4 * pagesize && (sectp->flags & SEC_RELOC) == 0
Paul>       && (abfd->flags & BFD_IN_MEMORY) == 0)

I don't know the answer to either of these.
If nobody here knows, I suggest asking on the binutils list.
If they aren't ok, maybe we could add a new BFD function for this.

Tom

References:
- [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
  - From: Paul Pluzhnikov
- Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
  - From: Tom Tromey
- Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
  - From: Paul Pluzhnikov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]