This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[patch] varobj regression by python


Hi,

the recent Python check-in
	http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/varobj.c.diff?cvsroot=src&r1=1.130&r2=1.131
regressed a new testcase
	gdb.mi/mi-var-cmd.exp: in-and-out-of-scope: out of scope now, not changed
checked-in recently by
	http://sourceware.org/ml/gdb-patches/2009-05/msg00343.html
.

Thanks,
Jan


2009-05-29  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* varobj.c (varobj_update): Fix out of scope varobjs to not to change.

--- gdb/varobj.c	28 May 2009 01:09:19 -0000	1.131
+++ gdb/varobj.c	29 May 2009 17:41:59 -0000
@@ -1539,7 +1539,8 @@ VEC(varobj_update_result) *varobj_update
 
       if (r.status == VAROBJ_NOT_IN_SCOPE)
 	{
-	  VEC_safe_push (varobj_update_result, result, &r);
+	  if (r.type_changed || r.changed)
+	    VEC_safe_push (varobj_update_result, result, &r);
 	  return result;
 	}
             


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]