This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] fix break-always test
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: Michael Snyder <msnyder at vmware dot com>, vladimir at codesourcery dot com
- Date: Sat, 30 May 2009 00:56:42 +0100
- Subject: Re: [PATCH] fix break-always test
- References: <4A2072C1.9000409@vmware.com>
On Saturday 30 May 2009 00:41:53, Michael Snyder wrote:
> "set breakpoint always" does not accept "1", it wants "on".
>
(gdb) set breakpoint always-inserted 1
Undefined item: "1".
(gdb) PASS: gdb.base/break-always.exp: set breakpoint always-inserted 1
Outch, this used to work, until set breakpoint always-inserted
was made into a three-state. Yikes, this has been broken for months.
My fault, as usual. :-)
> 2009-05-29 Michael Snyder <msnyder@vmware.com>
>
> * gdb.base/break-always.exp: Change "1" to "on".
This is certainly OK.
It would be a nice improvent to make the test confirm that
the mode is in effect, perhaps by just reading back the setting
with "show breakpoint always-inserted".
--
Pedro Alves