This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA/Windows] Remove ADD_SHARED_SYMBOL_FILES macro

From: Pedro Alves <pedro at codesourcery dot com>
To: gdb-patches at sourceware dot org
Cc: Joel Brobecker <brobecker at adacore dot com>, Pierre Muller <muller at ics dot u-strasbg dot fr>
Date: Tue, 26 May 2009 00:14:02 +0100
Subject: Re: [RFA/Windows] Remove ADD_SHARED_SYMBOL_FILES macro
References: <003d01c9d4e2$987399a0$c95acce0$@u-strasbg.fr> <006e01c9dd14$5a9cf510$0fd6df30$@u-strasbg.fr> <20090525225725.GI23016@adacore.com>

On Monday 25 May 2009 23:57:25, Joel Brobecker wrote:
> >        (_initialize _symfile): Move "add-shared-symbol-files"
> >        command and "assf" alias.
> >        * windows-nat.c (_initialize_windows_nat): to here.
> >        Change "add-shared-symbol-files" to alias.
> 
> I propose we deprecate these aliases as well; does it really make sense
> to have 2 identical commands?
> 

Well, let me go the other way around.  Why is "dll-symbols" needed
at all?  Why isn't "add-symbol-file" good enough?  Other than the
ugly safe_symbol_file_add hack that would be nice to get rid of,
and setting OBJF_SHARED (itself dubious) it doesn't have anything Windows
specific at all (magically appending ".dll" doesn't count).

-- 
Pedro Alves

References:
- [RFA] Remove ADD_SHARED_SYMBOL_FILES macro
  - From: Pierre Muller
- RE: [RFA/Windows] Remove ADD_SHARED_SYMBOL_FILES macro
  - From: Pierre Muller
- Re: [RFA/Windows] Remove ADD_SHARED_SYMBOL_FILES macro
  - From: Joel Brobecker

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]